Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unban functionality in dropdown #7510

Closed
wants to merge 12 commits into from
Closed

Unban functionality in dropdown #7510

wants to merge 12 commits into from

Conversation

sssash18
Copy link
Contributor

Fixes #7507 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!
New Behaviour
Untitled_ Feb 16, 2020 1_22 PM

@sssash18 sssash18 requested a review from a team as a code owner February 16, 2020 07:56
@codecov
Copy link

codecov bot commented Feb 16, 2020 •
edited
Loading

Codecov Report

Merging #7510 into master will decrease coverage by 15.55%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7510       +/-   ##
===========================================
- Coverage   81.87%   66.32%   -15.56%     
===========================================
  Files          97       97               
  Lines        5612     5666       +54     
===========================================
- Hits         4595     3758      -837     
- Misses       1017     1908      +891
Impacted Files Coverage Δ
app/models/drupal_content_field_mapper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/drupal_content_field_map_editor.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/features_controller.rb 0.00% <0.00%> (-80.71%) ⬇️
app/controllers/search_controller.rb 41.86% <0.00%> (-55.82%) ⬇️
app/controllers/admin_controller.rb 22.36% <0.00%> (-55.70%) ⬇️
app/controllers/user_tags_controller.rb 37.14% <0.00%> (-47.15%) ⬇️
app/controllers/legacy_controller.rb 0.00% <0.00%> (-47.06%) ⬇️
app/services/execute_search.rb 55.55% <0.00%> (-38.89%) ⬇️
app/controllers/notes_controller.rb 47.30% <0.00%> (-36.10%) ⬇️
app/models/drupal_content_type_map.rb 57.14% <0.00%> (-35.72%) ⬇️
... and 24 more

@sssash18 sssash18 closed this Feb 16, 2020
@sssash18 sssash18 reopened this Feb 16, 2020
@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @sssash18 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7510-test_questions.png

7510-test_embeddable_grids.png

7510-test_signup.png

7510-test_viewing_the_settings_page.png

7510-test_tag_by_author_page.png

7510-test_wiki_page_with_inline_grids.png

7510-test_stats.png

7510-test_viewing_the_dashboard.png

7510-test_searching_an_item_from_the_homepage.png

7510-test_signup_modal_form_validation.png

7510-test_tag_stats.png

7510-test_login_modal_form_validation.png

7510-test_questions_shadow.png

7510-test_login_modal.png

7510-test_profile_page.png

7510-test_comments.png

7510-test_tags.png

7510-test_signup_modal.png

7510-test_wiki.png

7510-test_methods.png

7510-test_tag_page.png

7510-test_blog_page_with_location_modal.png

7510-test_tag_wildcard.png

7510-test_signup_modal_disabled_submit_button_on_empty_username.png

7510-test_embeddable_thumbnail_grids.png

7510-test_front_page_with_navbar_search_autocomplete.png

7510-test_spam_moderation_page.png

7510-test_login.png

7510-test_viewing_the_dropdown_menu.png

7510-test_viewing_question_post.png

7510-test_mobile_displays.png

7510-test_simple-data-grapher_powertag.png

7510-test_front.png

7510-test_question_page.png

7510-test_tag_contributors_page.png

7510-test_blog.png

7510-test_people.png

7510-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@cesswairimu cesswairimu added the hold Holding this until issue that depends on it is fixed/ waiting for confirmation if feature is needed label Feb 16, 2020
VladimirMikulic
VladimirMikulic approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly, @sssash18. Thanks.

@sssash18
Copy link
Contributor Author

@cesswairimu Any update on this?

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:05
@cesswairimu
Copy link
Collaborator

cesswairimu commented Sep 18, 2020 •
edited
Loading

@sssash18 sorry, this took a while but we got input from Jeff and Liz on the issue. Kindly take a look and see if its something you would be interested on implementing. Thanks

@cesswairimu
Copy link
Collaborator

#7507 (comment)

@cesswairimu
Copy link
Collaborator

This PR has been open for a long time and no activity/ reviews requested has not been addressed. We understand you might be busy and engaged on other things. I am closing this for now...please feel free to reopen if you get some time and would like to finish this. Rem to check if its still available before you reopen. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirMikulic VladimirMikulic VladimirMikulic approved these changes

@cesswairimu cesswairimu Awaiting requested review from cesswairimu

@SidharthBansal SidharthBansal Awaiting requested review from SidharthBansal

Assignees
No one assigned
Labels
hold Holding this until issue that depends on it is fixed/ waiting for confirmation if feature is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the unban functionality
4 participants
@sssash18 @plotsbot @cesswairimu @VladimirMikulic